Update to frozen spec ❄️ (v0.8.1) #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo in the implementation of ssz::Decode for BitVector, which caused it to be considered variable length!
Allow computing the difference of two bitfields of different lengths.
SSZ benches relied upon fixed_len_vec -- it is easier to just delete them and rebuild them later (when necessary)
In the case where we tried to access the committee of a shard that didn't have a committee in the current epoch, we were accessing elements beyond the end of the shuffling vector and panicking! This commit adds a check to make the failure safe and explicit.
There was a bug in our implementation of get_indexed_attestation whereby incorrect "committee indices" were used to index into the custody bitfield. The bug was only observable in the case where some bits of the custody bitfield were set to 1. The implementation has been simplified to remove the bug, and a test added.
* Remove redundant max operation checks. * Always supply both messages when checking attestation signatures -- allowing verification of an attestation with no signatures. * Swap the order of the fork and domain constant in `get_domain`, to match the spec.
michaelsproul
added
spec_change
paulhauner
added
ready-for-review
paulhauner
requested changes
Jul 29, 2019
There was a problem hiding this comment.
I've been through all of these files (phew).
It's looking good so far. There's one set of tests I want to add back in.
Next steps are to resolve these comments then try and merge master in. I'll take care of it from here (unless anyone wants to input, of course).
|
|
||
| if !verify_bitfield_length(&bitfield, committee.committee.len()) { | ||
| /* TODO(freeze): re-enable this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
typesandstate_processingto v0.8.1 of the spec.beacon_node,validator_clientand other top-level cratesRelated Issues
Still to do