Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove req_id from CustodyId #6589

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ackintosh
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Removed req_id from CustodyId because it's not used.

@ackintosh ackintosh added the ready-for-review The code is ready for review label Nov 18, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. das Data Availability Sampling and removed ready-for-review The code is ready for review labels Dec 16, 2024
@jimmygchen
Copy link
Member

@mergify queue

Copy link

mergify bot commented Dec 16, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #6589 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

@mergify dequeue

Copy link

mergify bot commented Dec 16, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6589 has been dequeued by a dequeue command.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link

mergify bot commented Dec 16, 2024

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Dec 16, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 16, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 75d9079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants