Write range sync tests in external event-driven form

[dapplion]

Issue Addressed

Re-write existing range sync tests into an event-driven format to accommodate the refactor introduced in

• Add individual by_range sync requests #6497

This format was introduced in

• Event-based block lookup tests #5534

and does not make assumptions about internal functions, it treats sync as a black box inputting actual events used in production.

Note: I've removed the generics used in range sync since now we don't unit test directly

[jimmygchen]

Nice! Looks clean and easy to read 👍

[dapplion]

    sync::tests::range::state_update_while_purging
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 86 filtered out; finished in 7.58s

──── STDERR:             network sync::tests::range::state_update_while_purging
thread 'sync::tests::range::state_update_while_purging' panicked at /home/runner/work/lighthouse/lighthouse/beacon_node/beacon_chain/src/test_utils.rs:904:14:
called `Result::unwrap()` on an `Err` value: ExecutionLayerMissing

This test is failing in CI after switching to async, but can't reproduce locally

[jimmygchen]

I managed to reproduce the failing test locally, not sure why it was passing before 🤔 We do need it in this case I think, so we might have uncovered a lurking issue - adding a mock execution layer fixed it.

The other changes look good, thanks!

[jimmygchen]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

Pull request #6618 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[jimmygchen]

@mergify dequeue

[mergify]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6618 has been dequeued by a dequeue command.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

[mergify]

dequeue

✅ The pull request has been removed from the queue default

[jimmygchen]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1c5be34