This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
[chore] Upgrade dependencies #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-se
commented
Jul 30, 2021
| // 公式が提供しているAppMentionEvent型では足りないプロパティがあるためGenericMessageEvent型を利用している | ||
| // see https://github.com/siiibo/shujinosuke/pull/16#discussion_r642349045 | ||
| handleAppMention(client, event as unknown as GenericMessageEvent); | ||
| handleAppMention(client, event as AppMentionEvent); |
There was a problem hiding this comment.
以前AppMentionEventにeditedがない状況について、 @slack/bolt の issueにて拙い英語で質問したところ、バグだということで修正していただけました。（どうせなら自分で修正してプルリク投げれば良かった...）
GenericMessageEventを使う必要がなくなったので代用してた部分を全て修正。
There was a problem hiding this comment.
すばらしい！！！
slackapi/bolt-js#960 ですね、GJ 👍
hi-se
commented
Jul 30, 2021
| if ((await client.users.getPresence({ user: remindTarget })).presence === 'active') { | ||
| if (client.users.getPresence({ user: remindTarget }).presence === 'active') { |
There was a problem hiding this comment.
slack clientをGAS用に置き換えた際、不要なPromiseが残ってしまっていたためここでaync/awaitを利用していました。
hi-se/gas-slack-sdk@e5964bf で対応したので、こちらも合わせて修正。
ymtszw
approved these changes
Jul 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slack/boltと@hi-se/web-apiのアップデートが主目的。
ライブラリのアップデートに伴ってコードを少し修正。
ついでに他のライブラリも最新のバージョンにアップデートした。