Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to get edited property from app_mention event using TypeScript? #960

Closed
4 of 10 tasks
hi-se opened this issue Jun 5, 2021 · 2 comments · Fixed by #961
Closed
4 of 10 tasks

How to get edited property from app_mention event using TypeScript? #960

hi-se opened this issue Jun 5, 2021 · 2 comments · Fixed by #961
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Milestone
3.4.1

Comments

@hi-se
Copy link

hi-se commented Jun 5, 2021 •
edited
Loading

Description

I am creating a Slack bot using TypeScript. (using types from bolt-js, but not bolt-js app)
When the app_mention event occur, the bot reply some message.

I want the bot to reply only once, but when the message is edited, the bot reply again.

The response from Slack server includes "edited" property, but AppMentionEvent type doesn't include it.
So, I'm using GenericMessageEvent for now...

Is there any better way to use "edited" property or any plan to change AppMentionEvent type?

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@gitwave gitwave bot added the untriaged label Jun 5, 2021
@seratch seratch mentioned this issue Jun 5, 2021
Merged
6 tasks
@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific and removed untriaged labels Jun 5, 2021
@seratch seratch added this to the 3.5.0 milestone Jun 5, 2021
@seratch
Copy link
Member

seratch commented Jun 5, 2021

Hi @hi-se, thanks for pointing this out! The property should be available in the interface. I will create a pull request shortly.

seratch added a commit to seratch/bolt-js that referenced this issue Jun 5, 2021
@seratch
Fix slackapi#960 by adding edited property to app_mention event payload
c9108c1
@seratch seratch mentioned this issue Jun 5, 2021
Merged
2 tasks
@hi-se
Copy link
Author

hi-se commented Jun 5, 2021

@seratch Thank you for your quick response!

@hi-se hi-se changed the title How to get "edited" property from app_mention event using TypeScript? How to get edited property from app_mention event using TypeScript? Jun 5, 2021
seratch added a commit that referenced this issue Jun 7, 2021
@seratch
Fix #960 by adding edited property to app_mention event payload (#961)
3be0410
@stevengill stevengill modified the milestones: 3.5.0, 3.4.1 Jun 30, 2021
@ymtszw ymtszw mentioned this issue Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Milestone
3.4.1
Development

Successfully merging a pull request may close this issue.

Fix #960 by adding edited property to app_mention event payload seratch/bolt-js
3 participants
@seratch @stevengill @hi-se