Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #960 by adding edited property to app_mention event payload #961

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 5, 2021

Summary

This pull request fixes #960 by adding edited property to AppMentionEvent interface. Refer to the issue for details.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jun 5, 2021
@seratch seratch added this to the 3.5.0 milestone Jun 5, 2021
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #961 (c9108c1) into main (6b1ab43) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files          13       13           
  Lines        1207     1207           
  Branches      356      356           
=======================================
  Hits          799      799           
  Misses        338      338           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1ab43...c9108c1. Read the comment docs.

@seratch seratch merged commit 3be0410 into slackapi:main Jun 7, 2021
@seratch seratch deleted the issue-960-edited-app-mention branch June 7, 2021 00:28
@stevengill stevengill modified the milestones: 3.5.0, 3.4.1 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get edited property from app_mention event using TypeScript?
3 participants