Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space added by \code as defined in packages/url #1056

Closed
jmaibaum opened this issue Sep 12, 2020 · 2 comments · Fixed by #1057
Closed

Extra space added by \code as defined in packages/url #1056

jmaibaum opened this issue Sep 12, 2020 · 2 comments · Fixed by #1057
Labels
bug Software bug issue
Milestone

Comments

@jmaibaum
Copy link
Contributor

Using SILE 0.10.10, and typesetting the following example:

\begin{document}
\script[src=packages/url]
The \code{\\code} command defined in \code{packages/url} typesets an extra space at the end, see:
\url{https://github.com/sile-typesetter/sile/blob/bd7e52e75663b861ee0bb57876204e740f518fbc/packages/url.lua#L47}.
Most likely I simply don’t know the use cases this extra space enables, but to the casual user,
this looks like a clear bug.
\end{document}

produces this output:

Bildschirmfoto von 2020-09-12 17-45-04

SILE.typesetter:typeset(" ")

Commenting out the line locally fixes the example above:

Bildschirmfoto von 2020-09-12 17-42-08

Does not typesetting this extra space break important stuff elsewhere?

I stumbled upon this while trying out @alerque's WIP SILE writer for pandoc PR where using the standard markdown backticks syntax ends up using the \code command from packages/url.

@jmaibaum
Copy link
Contributor Author

In case this is considered a bug, I have just filed a quick PR.

jmaibaum added a commit to jmaibaum/sile that referenced this issue Sep 14, 2020
@alerque alerque added the bug Software bug issue label Sep 14, 2020
@alerque
Copy link
Member

alerque commented Sep 14, 2020

That looked pretty bizarre to me. I was even more chagrined to run git blame on the original \code function and find it tracked back to my commit 50fc3b3 with no explanation for the space.

@alerque alerque added this to the v0.10.11 milestone Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants