Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra space in \code from packages/url #1057

Merged

Conversation

jmaibaum
Copy link
Contributor

Closes #1056

@jmaibaum jmaibaum force-pushed the remove-extra-space-after-code-command branch from 3ef5135 to b90cd37 Compare September 14, 2020 06:15
@alerque alerque force-pushed the remove-extra-space-after-code-command branch from eb10a96 to 08d719d Compare September 14, 2020 09:27
@alerque
Copy link
Member

alerque commented Sep 14, 2020

Thanks for taking the time to contribute this fix. I've tacked on a bit of a refactor that takes a convoluted set of steps and boils it down to about as simple as you can make it. Technically \code is not documented to take any arguments so it probably could get away without passing that through, but given it could be extended I guess this is okay too.

@alerque alerque added the bug Software bug issue label Sep 14, 2020
@alerque alerque added this to the v0.10.11 milestone Sep 14, 2020
@alerque alerque merged commit 373305f into sile-typesetter:master Sep 14, 2020
@jmaibaum jmaibaum deleted the remove-extra-space-after-code-command branch September 19, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra space added by \code as defined in packages/url
2 participants