This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Use composer install to install dependencies #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
composer install
instead ofcomposer update
to install dependencies.The point of the
composer.lock
file is to allow reproducible dependency installs across environments/projects. To use theupdate
command during CI means that we get non-reproducible results and that we ship an untested lock file with our projects.Not only this, but the use of
update
instead ofinstall
is having quite profound impacts on CI build times. Looking at the mfa module as an example, installation times have gone from 25 seconds to 3.5 minutes when switching frominstall
toupdate
.Unless there's some undocumented reason as to why
update
is preferred toinstall
, this should be changed