Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

FIX Use composer update for prefer-lowest #36

Merged
merged 1 commit into from
Apr 20, 2022
Merged

FIX Use composer update for prefer-lowest #36

merged 1 commit into from
Apr 20, 2022

Conversation

emteknetnz
Copy link
Member

Fixes this https://app.travis-ci.com/github/silverstripe/silverstripe-framework/jobs/567064712

Happened after we optimised to use composer install instead of composer update #35

@emteknetnz emteknetnz requested a review from dhensby April 20, 2022 05:00
This was referenced Apr 20, 2022
Merged
Closed
Merged
@dhensby
Copy link
Contributor

dhensby commented Apr 20, 2022

Well, we can see that the install vs update hasn't really made any speed difference, which was the main aim of #35. It may just be more reliable to simply use update everywhere like we were before?

@emteknetnz emteknetnz force-pushed the pulls/master/prefer-lowest branch from ec3325c to 2d0df90 Compare April 20, 2022 22:34
@emteknetnz
Copy link
Member Author

emteknetnz commented Apr 20, 2022 •
edited
Loading

Yup install is functionally the same speed as update - I've updated the PR to revert back to composer update and added some comments for explanation

@GuySartorelli GuySartorelli merged commit 8ade073 into silverstripe:master Apr 20, 2022
@GuySartorelli GuySartorelli deleted the pulls/master/prefer-lowest branch April 20, 2022 22:56
@GuySartorelli GuySartorelli mentioned this pull request Apr 22, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

@dhensby dhensby Awaiting requested review from dhensby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @dhensby @GuySartorelli