Add support for webkit (#56)

Thanks, @rdmurphy
simonw · Apr 11, 2022 · 0b0b3c7 · 0b0b3c7
1 parent 345e488
commit 0b0b3c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/shot_scraper/cli.py b/shot_scraper/cli.py
@@ -13,7 +13,7 @@
 
 from shot_scraper.utils import filename_for_url, url_or_file_path
 
-BROWSERS = ("chromium", "firefox", "chrome", "chrome-beta")
+BROWSERS = ("chromium", "firefox", "webkit", "chrome", "chrome-beta")
 
 
 def browser_option(fn):
@@ -234,6 +234,8 @@ def _browser_context(
         browser_obj = p.chromium.launch(**browser_kwargs)
     elif browser == "firefox":
         browser_obj = p.firefox.launch(**browser_kwargs)
+    elif browser == "webkit":
+        browser_obj = p.webkit.launch(**browser_kwargs)
     else:
         browser_kwargs["channel"] = browser
         browser_obj = p.chromium.launch(**browser_kwargs)

diff --git a/tests/run_examples.sh b/tests/run_examples.sh
@@ -77,6 +77,8 @@ shot-scraper 'https://www.whatismybrowser.com/detect/what-is-my-user-agent/' \
   -o /tmp/whatismybrowser-default-chromium.png -h 400 -w 800
 shot-scraper 'https://www.whatismybrowser.com/detect/what-is-my-user-agent/' \
   -o /tmp/whatismybrowser-firefox.png -h 400 -w 800 -b firefox
+shot-scraper 'https://www.whatismybrowser.com/detect/what-is-my-user-agent/' \
+  -o /tmp/whatismybrowser-webkit.png -h 400 -w 800 -b webkit
 # And using multi
 echo '# empty file' > empty.yml
 shot-scraper multi empty.yml