-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for webkit #56
Conversation
I skipped
I'm confident it's possible to get it working, but I think the code here needs some fixes: shot-scraper/shot_scraper/cli.py Lines 210 to 217 in 4dc9c36
|
@simonw Derp — sorry about that. I had another branch in flight where I added that but forgot to pull it into this. Should be good now! |
Tested this with:
And:
|
So that WebKit can work, refs #56
Not sure why
webkit
was excluded seeing as it's one of the three major browsers supported by Playwright, but this PR adds it.