-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update use of numpy
's random number generators.
#360
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 86.25% 86.28% +0.03%
==========================================
Files 89 89
Lines 18695 18717 +22
Branches 2959 2961 +2
==========================================
+ Hits 16125 16150 +25
+ Misses 1884 1881 -3
Partials 686 686 ☔ View full report in Codecov by Sentry. |
simplex passes tree tests passing cyl passing boundaries passing, also removes pymatsolver imports base passes
numpy
\'s random number generators.
numpy
\'s random number generators.numpy
's random number generators.
Believe this is ready to go now. Only thing to discuss is the name of the keyword. I put it as The other thing is that I made it so you can't easily set the random number generator for the success/fail messages. I think it's more interesting to keep getting different random messages. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I noticed that this PR also replaces the pymatsolver
solvers for the scipy ones. I think it's ok if you want to leave those changes in this PR as long as we add it to the list of changes in the description and in the commit message.
Allow the use of numpy's default random number generator in discretize. Still a bit of work to do to make it complete though.