-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discretize 0.1.10 #73
Conversation
lheagy
commented
Sep 21, 2017
- properties: injection of properties into discretize from Ref/properties #70. This allows meshes to be serialized, saved, and loaded.
- Tree Mesh Cell Grad (@fourndo) : implement a cell gradient for the Tree mesh from Tree mesh cell grad #72
- 3D Cyl Mesh: first implementation of a 3D cyl mesh from 3D Cyl Mesh #36. This also makes the cell grad stencils properties rather than functions
…y, add a check to ensure the cartesian origin is being set properly. Have x0 be passed as a kwarg in meshIO
…ent/properties#191, test serialization and deserialization of tree mesh
…the testing to make sure errors are raised if the user messes with n.
…rialize onto BaseMesh rather than properties.HasProperties
Ref/properties
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 76.98% 76.98% +<.01%
==========================================
Files 17 17
Lines 4797 4858 +61
==========================================
+ Hits 3693 3740 +47
- Misses 1104 1118 +14
Continue to review full report at Codecov.
|
I would like to change the scope of this and bring it in as-is. The cyl mesh changes and Tree Mesh cell grad can be separate releases (and directly onto master). @fourndo, does this work with you? |