Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discretize 0.1.10 #73

Merged
merged 36 commits into from
Dec 5, 2017
Merged

discretize 0.1.10 #73

merged 36 commits into from
Dec 5, 2017

Conversation

lheagy
Copy link
Member

@lheagy lheagy commented Sep 21, 2017

  • properties: injection of properties into discretize from Ref/properties #70. This allows meshes to be serialized, saved, and loaded.
  • Tree Mesh Cell Grad (@fourndo) : implement a cell gradient for the Tree mesh from Tree mesh cell grad #72
  • 3D Cyl Mesh: first implementation of a 3D cyl mesh from 3D Cyl Mesh #36. This also makes the cell grad stencils properties rather than functions

lheagy added 30 commits August 30, 2017 22:42
…y, add a check to ensure the cartesian origin is being set properly. Have x0 be passed as a kwarg in meshIO
…the testing to make sure errors are raised if the user messes with n.
…rialize onto BaseMesh rather than properties.HasProperties
@codecov
Copy link

codecov bot commented Sep 21, 2017

Codecov Report

Merging #73 into master will increase coverage by <.01%.
The diff coverage is 86.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   76.98%   76.98%   +<.01%     
==========================================
  Files          17       17              
  Lines        4797     4858      +61     
==========================================
+ Hits         3693     3740      +47     
- Misses       1104     1118      +14
Impacted Files Coverage Δ
discretize/View.py 4.91% <0%> (ø) ⬆️
discretize/CurvilinearMesh.py 99.4% <100%> (+0.02%) ⬆️
discretize/MeshIO.py 83.56% <100%> (+0.47%) ⬆️
discretize/utils/meshutils.py 69.35% <100%> (ø) ⬆️
discretize/BaseMesh.py 83.81% <77.19%> (-1.77%) ⬇️
discretize/TensorMesh.py 90.9% <85.71%> (-1.13%) ⬇️
discretize/utils/__init__.py 85.71% <85.71%> (+1.09%) ⬆️
discretize/CylMesh.py 84.61% <90.9%> (-0.04%) ⬇️
discretize/TreeMesh.py 82.8% <94.44%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa11a0a...ca5b114. Read the comment docs.

@lheagy lheagy mentioned this pull request Nov 13, 2017
5 tasks
@lheagy
Copy link
Member Author

lheagy commented Nov 16, 2017

I would like to change the scope of this and bring it in as-is. The cyl mesh changes and Tree Mesh cell grad can be separate releases (and directly onto master). @fourndo, does this work with you?

@lheagy lheagy merged commit d88c1f0 into master Dec 5, 2017
@lheagy lheagy deleted the dev branch December 5, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant