Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App Annie icon #5353

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Conversation

LitoMore
Copy link
Member

Issue: #5352
Alexa rank: 3,532

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I pick the hex value from App Annie's primary button color.

@LitoMore LitoMore force-pushed the app-annie branch 8 times, most recently from c92d35b to 9405606 Compare March 26, 2021 13:22
@service-paradis service-paradis linked an issue Mar 26, 2021 that may be closed by this pull request
@LitoMore LitoMore force-pushed the app-annie branch 2 times, most recently from 57d1558 to 6ee14b5 Compare March 27, 2021 07:11
@adamrusted adamrusted added the new icon Issues or pull requests for adding a new icon label Mar 27, 2021
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @LitoMore!
As you can see here there are quite a few differences between your PR (red) and the source file (black). This is a particularly difficult one to work with, purely on the unnecessary paths in the clipping mask, but would you mind taking another look at it?
It also looks like their primary colour (from the UI screenshots) is actually the dark blue. Do you think that hex would better represent the brand?

Looks like there are officially provided EPS files on their press page (including a monochrome treatment), so it may be worth using those - and updating the source link to that specific page.

@LitoMore
Copy link
Member Author

LitoMore commented Mar 28, 2021

Hi @adamrusted, I updated the icon by using the EPS source file. But I got some problems with the icon size.

image

You can see that the height is not an integer, then the CI reported this:

x icon-centered <path> must be centered at (12, 12); the center is currently (12, 12.237)

Do you have any solution for this? Or accept it?

@adamrusted
Copy link
Member

You can see that the height is not an integer, then the CI reported this:

x icon-centered <path> must be centered at (12, 12); the center is currently (12, 12.237)

Providing the icon is centered to a 24*24 canvas, the fact it's not an integer shouldn't be an issue. You may just need to raise the precision in both your SVG export and the SVGO config file. A precision of 4 across the board may fix that.

@fbernhart
Copy link
Contributor

fbernhart commented Mar 28, 2021

@LitoMore The SVG has to have a size of maximum 24px x 24px. Therefore you have to scale down the icon first, so that the larger size (the height in your case) is 24px. While keeping the aspect ration, the width should then be around 24/24.47x24 = 23.539px.

After it has the appropriate size, you can then center it.

@LitoMore
Copy link
Member Author

@adamrusted @fbernhart Thanks. Let me try.

@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @LitoMore?

@LitoMore
Copy link
Member Author

@PeterShaggyNoble Ah yes, I'm using Sketch for editing this icon, but it supports only 0.00 precision. I'm looking for a new application to edit this.

@PeterShaggyNoble
Copy link
Member

Inkscape is a decent, free SVG editor if you want to give that a try.

@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @LitoMore?

@LitoMore
Copy link
Member Author

Ah yes. Let me continue this work.

@PeterShaggyNoble
Copy link
Member

Any update, @LitoMore? We're going to try to work through some of our backlog this weekend so it would be good to get this one merged, if we can.

@LitoMore
Copy link
Member Author

LitoMore commented Jun 16, 2021

@PeterShaggyNoble @adamrusted Updated.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LitoMore, that lines up perfectly now 👍🏻 However, there are a couple of excess points on the leftmost and rightmost corners that you should be able to remove. Also, could you update the source to https://www.appannie.com/en/about/press/, please?

@LitoMore
Copy link
Member Author

@PeterShaggyNoble Thanks! Updated!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @LitoMore, everything looks perfect to me 👍🏻 Thanks again for the contribution.

@PeterShaggyNoble PeterShaggyNoble merged commit 73e8761 into simple-icons:develop Jun 23, 2021
@LitoMore LitoMore deleted the app-annie branch June 23, 2021 14:49
@github-actions github-actions bot mentioned this pull request Jun 27, 2021
ericcornelissen added a commit that referenced this pull request Jun 27, 2021
# New Icons

- Adidas (#5917)
- AEW (#5971)
- App Annie (#5353)
- Cytoscape.js (#5968)
- ExpressVPN (#6001)
- Frontend Mentor (#5746)
- Jordan (#5920)
- KFC (#6025)
- Konva (#5797)
- Nette (#5821)
- Nike (#5916)
- NordVPN (#5908)
- Protractor (#5999)
- Puma (#5919)
- PyScaffold (#5866)
- React Table (#5979)
- Reebok (#5921)
- Sequelize (#4539)
- Spond (#5995)
- Starbucks (#5910)
dirien pushed a commit to dirien/simple-icons that referenced this pull request Jul 20, 2021
@adamrusted adamrusted removed their request for review November 15, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add App Annie icon
4 participants