-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App Annie icon #5353
Add App Annie icon #5353
Conversation
c92d35b
to
9405606
Compare
57d1558
to
6ee14b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @LitoMore!
As you can see here there are quite a few differences between your PR (red) and the source file (black). This is a particularly difficult one to work with, purely on the unnecessary paths in the clipping mask, but would you mind taking another look at it?
It also looks like their primary colour (from the UI screenshots) is actually the dark blue. Do you think that hex would better represent the brand?
Looks like there are officially provided EPS files on their press page (including a monochrome treatment), so it may be worth using those - and updating the source link to that specific page.
Hi @adamrusted, I updated the icon by using the EPS source file. But I got some problems with the icon size. You can see that the height is not an integer, then the CI reported this:
Do you have any solution for this? Or accept it? |
Providing the icon is centered to a 24*24 canvas, the fact it's not an integer shouldn't be an issue. You may just need to raise the precision in both your SVG export and the SVGO config file. A precision of 4 across the board may fix that. |
@LitoMore The SVG has to have a size of maximum 24px x 24px. Therefore you have to scale down the icon first, so that the larger size (the height in your case) is 24px. While keeping the aspect ration, the width should then be around 24/24.47x24 = 23.539px. After it has the appropriate size, you can then center it. |
@adamrusted @fbernhart Thanks. Let me try. |
Are you still working on this one, @LitoMore? |
@PeterShaggyNoble Ah yes, I'm using Sketch for editing this icon, but it supports only |
Inkscape is a decent, free SVG editor if you want to give that a try. |
Are you still working on this one, @LitoMore? |
Ah yes. Let me continue this work. |
Any update, @LitoMore? We're going to try to work through some of our backlog this weekend so it would be good to get this one merged, if we can. |
@PeterShaggyNoble @adamrusted Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @LitoMore, that lines up perfectly now 👍🏻 However, there are a couple of excess points on the leftmost and rightmost corners that you should be able to remove. Also, could you update the source to https://www.appannie.com/en/about/press/, please?
@PeterShaggyNoble Thanks! Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @LitoMore, everything looks perfect to me 👍🏻 Thanks again for the contribution.
# New Icons - Adidas (#5917) - AEW (#5971) - App Annie (#5353) - Cytoscape.js (#5968) - ExpressVPN (#6001) - Frontend Mentor (#5746) - Jordan (#5920) - KFC (#6025) - Konva (#5797) - Nette (#5821) - Nike (#5916) - NordVPN (#5908) - Protractor (#5999) - Puma (#5919) - PyScaffold (#5866) - React Table (#5979) - Reebok (#5921) - Sequelize (#4539) - Spond (#5995) - Starbucks (#5910)
Issue: #5352
Alexa rank: 3,532
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I pick the hex value from App Annie's primary button color.