Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starbucks #5910

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Add Starbucks #5910

merged 3 commits into from
Jun 23, 2021

Conversation

huuphongsan
Copy link
Contributor

@huuphongsan huuphongsan commented Jun 10, 2021

starbucks

🤯 Starbucks has a magic logo. If I use their green's brand color in background and white in main logo, everything will be like "something wrong". Because Simple Icons Preview cannot apply color in main logo except black color, so I think I have add another Preview.

starbucks (1)

Issue: Closes #5757
Alexa rank: 4938

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 10, 2021
@PeterShaggyNoble
Copy link
Member

Thanks for taking this one on, @huuphongnguyen 👍🏻

The SVG looks good to me. Just 2 small changes and this should be ready to merge: from this page, the colour should be #006241, and could you add https://creative.starbucks.com/ as the guidelines entry in the JSON, please?

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @huuphongnguyen, everything looks good to me now - nice work 👍🏻

@PeterShaggyNoble PeterShaggyNoble merged commit fedeebc into simple-icons:develop Jun 23, 2021
@github-actions github-actions bot mentioned this pull request Jun 27, 2021
ericcornelissen added a commit that referenced this pull request Jun 27, 2021
# New Icons

- Adidas (#5917)
- AEW (#5971)
- App Annie (#5353)
- Cytoscape.js (#5968)
- ExpressVPN (#6001)
- Frontend Mentor (#5746)
- Jordan (#5920)
- KFC (#6025)
- Konva (#5797)
- Nette (#5821)
- Nike (#5916)
- NordVPN (#5908)
- Protractor (#5999)
- Puma (#5919)
- PyScaffold (#5866)
- React Table (#5979)
- Reebok (#5921)
- Sequelize (#4539)
- Spond (#5995)
- Starbucks (#5910)
dirien pushed a commit to dirien/simple-icons that referenced this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starbucks
2 participants