-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purgecss #5400
Purgecss #5400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @stefanobartoletti!
I've been able to find this SVG from within their repo, which seems to be our best shot at an SVG logo. Would you mind updating the source to that, and using the SVG as your base?
Done, the file itself is slightly bigger in size, because of some slightly different points from the one I vectorized myself |
Thanks for the update, @stefanobartoletti. As this is based on a Potraced SVG, which butchers the source file to begin with, I think we can let the differences between your redrawn circle and the circle in the source slide - it's clearly meant to be a perfect circle. There is a difference running up the bottom left of the "P" that we should probably try to fix, though. Could you also see if you could clean up some of the excess points. We'll also need to update the source URL to the GitHub commit URL. |
I tried to further optimize this icon according to your suggestions. This is the best I can do on this. |
Nice one, @stefanobartoletti 👍🏻 Given the poor quality of the source SVG and original PNG, this looks good enough to me. How about you, @adamrusted? The only other change needed is to update the source URL to https://github.com/FullHuman/purgecss/blob/4e2bf58e218119cc9faf9faa615d62a059bf9d9a/docs/.vuepress/public/safari-pinned-tab.svg |
Yep, looks good to me if @stefanobartoletti could update the source URL we can get this merged. Thanks for your work, and to @PeterShaggyNoble for looking at this also! 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @stefanobartoletti - let's get this merged in ahead of this weekends release! 🚀
# New Icons - CLion (#5447) - EditorConfig (#5237) - FontBase (#5402) - Hasura (#5452) - Imou (#5458) - Klarna (#5441) - MediaTek (#5171) - Mumble (#4874) - Passport (#5054) - PurgeCSS (#5400) - Shelly (#5216) - Storyblok (#5399) - UpCloud (#5444) - Verdaccio (#5450) - Vite (#5401) # Updated Icons - Dior (#5314) - Gitpod (#5425) - GNU Bash (#5460) - GNU Emacs (#5460) - GNU IceCat (#5460) - GNU Privacy Guard (#5460) - Loom (#5378) - Raspberry Pi (#5339) - Trello (#5459) - Xiaomi (#5426)
Issue:
GitHub Stars: 6k +
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I vectorized the PNG logo from their website, where I took the color as well