Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Verdaccio #5450

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

raeffs
Copy link
Contributor

@raeffs raeffs commented Apr 13, 2021

verdaccio

Issue: Closes #5422
Alexa rank: 733270
GitHub stars: ~11k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I used the black and white SVG from their website, removed unnecessary elements and combined all the paths to one. The hex value is the one from their websites header. It's almost the same value used in the icon itself, just slightly different (I wasn't able to see any difference).

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 13, 2021
@raeffs

This comment has been minimized.

@raeffs

This comment has been minimized.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Simple Icons, @raeffs, and thanks for the contribution 🙂

Everything looks good to me 👍🏻 There are a couple of minor differences arising from the removal of the left path of the "v" but I think that's OK as it looks to be an imperfection in the original rather than intentional.

I also think that's the correct choice for the colour; it's also used for text & links throughout the site. The other option, though, would be the darker #405236 from the full colour SVGs.

I don't think we need the guidelines entry here as the source page doesn't include any additional information about the branding or usage of the icon. Once that change is made, this can be merged straight in.

@raeffs
Copy link
Contributor Author

raeffs commented Apr 14, 2021

@PeterShaggyNoble I removed the guidelines entry

@PeterShaggyNoble PeterShaggyNoble merged commit a9bc403 into simple-icons:develop Apr 14, 2021
@PeterShaggyNoble
Copy link
Member

Thanks for the quick update and for your work on this, @raeffs 👍🏻

If anyone feels that the imperfection in the original was intentional or that there's a better choice of colour, we can address that in a separate PR.

@raeffs
Copy link
Contributor Author

raeffs commented Apr 14, 2021

sounds good 👍🏻

@juanpicado
Copy link

This so cool 😎:) looking forward seeing online, thanks @raeffs

@PeterShaggyNoble
Copy link
Member

It will be available from this coming Sunday, @juanpicado.

ericcornelissen added a commit that referenced this pull request Apr 18, 2021
# New Icons

- CLion (#5447)
- EditorConfig (#5237)
- FontBase (#5402)
- Hasura (#5452)
- Imou (#5458)
- Klarna (#5441)
- MediaTek (#5171)
- Mumble (#4874)
- Passport (#5054)
- PurgeCSS (#5400)
- Shelly (#5216)
- Storyblok (#5399)
- UpCloud (#5444)
- Verdaccio (#5450)
- Vite (#5401)

# Updated Icons

- Dior (#5314)
- Gitpod (#5425)
- GNU Bash (#5460)
- GNU Emacs (#5460)
- GNU IceCat (#5460)
- GNU Privacy Guard (#5460)
- Loom (#5378)
- Raspberry Pi (#5339)
- Trello (#5459)
- Xiaomi (#5426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Verdaccio
3 participants