Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directive check in no-empty-file for TypeScript parser #2180

Merged
merged 4 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@babel/core": "^7.22.8",
"@babel/eslint-parser": "^7.22.7",
"@lubien/fixture-beta-package": "^1.0.0-beta.1",
"@typescript-eslint/parser": "^5.61.0",
"@typescript-eslint/parser": "^6.2.0",
"ava": "^3.15.0",
"c8": "^8.0.0",
"chalk": "^5.3.0",
Expand Down
2 changes: 1 addition & 1 deletion rules/no-empty-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const messages = {
[MESSAGE_ID]: 'Empty files are not allowed.',
};

const isDirective = node => node.type === 'ExpressionStatement' && 'directive' in node;
const isDirective = node => node.type === 'ExpressionStatement' && typeof node.directive === 'string';
const isEmpty = node => isEmptyNode(node, isDirective);

const isTripleSlashDirective = node =>
Expand Down
2 changes: 2 additions & 0 deletions test/integration/projects.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,8 @@ export default [
'aio/tools/transforms/authors-package/index.js', // This file use `package` keyword as variable
'packages/compiler-cli/test/**',
'tools/**',
// TODO[@fisker]: Check why it can't be parsed
'packages/forms/src/validators.ts',
],
},
// OOM
Expand Down
11 changes: 11 additions & 0 deletions test/no-empty-file.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,14 @@ test.snapshot({
].map(extension => ({code: '{}', filename: `example.${extension}`})),
],
});

// Test for https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2175
test.typescript({
valid: [
{code: '(() => {})();', filename: 'example.ts'},
],
invalid: [
{code: '"";', filename: 'example.ts', errors: 1},
fisker marked this conversation as resolved.
Show resolved Hide resolved
{code: '"use strict";', filename: 'example.ts', errors: 1},
],
});