Fix directive check in no-empty-file for TypeScript parser
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
changed the title
no-empty-file for TypeScript parser
fisker
reviewed
Jul 25, 2023
fisker
reviewed
Jul 25, 2023
fisker
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2175
To ensure the fix is valid, I
updated the @typescript-eslint/parser dev dependency andadded a few simpletest.typescriptcases tono-empty-filetests. I attempted to update@typescript-eslint/parserto v6, but it caused the angular integration test to fail, so I reverted that change. Given that this is still being tested on the v5 parser, the tests I added don't actually do much yet, but will provide checks once the parser is upgraded.Please let me know if there's any additional testing I can / should add to this PR!