Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directive check in no-empty-file for TypeScript parser #2180

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Fix directive check in no-empty-file for TypeScript parser #2180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
362255e
Fix directive check in no-empty-file for TypeScript parser
mcous Jul 23, 2023
83005fc
Apply suggestions from code review
fisker Jul 25, 2023
6b83eba
Update `@typescript-eslint/parser` to v6
fisker Jul 25, 2023
90142d6
Disable one test
fisker Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/no-empty-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const messages = {
[MESSAGE_ID]: 'Empty files are not allowed.',
};

const isDirective = node => node.type === 'ExpressionStatement' && 'directive' in node;
const isDirective = node => node.type === 'ExpressionStatement' && node.directive !== undefined;
fisker marked this conversation as resolved.
Show resolved Hide resolved
const isEmpty = node => isEmptyNode(node, isDirective);

const isTripleSlashDirective = node =>
Expand Down
10 changes: 10 additions & 0 deletions test/no-empty-file.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,13 @@ test.snapshot({
].map(extension => ({code: '{}', filename: `example.${extension}`})),
],
});

// Test for https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2175
test.typescript({
valid: [
{code: '(() => {})();', filename: 'example.ts'},
],
invalid: [
{code: '"";', filename: 'example.ts', errors: 1},
fisker marked this conversation as resolved.
Show resolved Hide resolved
],
});