Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TypeScript strict mode #356

Merged
merged 8 commits into from
Sep 17, 2019
Merged

Enable TypeScript strict mode #356

merged 8 commits into from
Sep 17, 2019

Conversation

satyarohith
Copy link
Contributor

@satyarohith satyarohith commented Feb 20, 2019 •
edited
Loading

We need definitions for the below modules before we proceed.

closes #350

@rahgurung rahgurung mentioned this pull request Feb 20, 2019
Closed
@satyarohith

This comment has been minimized.

Sign in to view
@sindresorhus

This comment has been minimized.

Sign in to view
@satyarohith

This comment has been minimized.

Sign in to view
@sindresorhus
Copy link
Owner

sindresorhus commented Mar 18, 2019 •
edited
Loading

Shall I just declare module for png-js?

Yes

satyarohith
satyarohith commented Mar 20, 2019
View reviewed changes
test/cookie.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus requested changes Mar 21, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/cookie.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@satyarohith satyarohith force-pushed the enable-ts-strict branch 2 times, most recently from 2e73b2a to 0aec381 Compare March 23, 2019 02:18
@satyarohith satyarohith changed the title [WIP] Enable TypeScript strict mode Enable TypeScript strict mode Mar 23, 2019
@satyarohith
Copy link
Contributor Author

satyarohith commented Mar 23, 2019 •
edited
Loading

@sindresorhus Maybe a rerun might fix the tests. It's due to the upgrade of filenamify-url. I have raised an issue here.

@satyarohith satyarohith mentioned this pull request Mar 23, 2019
Merged
@satyarohith satyarohith force-pushed the enable-ts-strict branch 3 times, most recently from 231e209 to 0cd8423 Compare March 23, 2019 07:24
@sindresorhus sindresorhus mentioned this pull request May 23, 2019
Closed
@satyarohith satyarohith mentioned this pull request Jun 12, 2019
Merged
@satyarohith
Copy link
Contributor Author

Ping!

@sindresorhus
Copy link
Owner

Also upgrade to latest TypeScript and other dependencies to ensure the types are still valid.

sindresorhus
sindresorhus requested changes Sep 10, 2019
View reviewed changes
package.json Show resolved Hide resolved
source/index.ts Outdated Show resolved Hide resolved
test/_server.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
Satya Rohith and others added 6 commits September 10, 2019 13:57
@satyarohith
Copy link
Contributor Author

@sindresorhus I have updated the PR. :)

@sindresorhus sindresorhus merged commit af5540f into sindresorhus:master Sep 17, 2019
@sindresorhus
Copy link
Owner

Looks good. Thanks :)

@satyarohith satyarohith deleted the enable-ts-strict branch September 17, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable TypeScript strict mode
2 participants
@satyarohith @sindresorhus