Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict TS #371

Closed
wants to merge 1 commit into from
Closed

Conversation

lucasavila00
Copy link

@lucasavila00 lucasavila00 commented May 23, 2019

Fixes #350

Notes: Using filenamify-url, unless in version 1.0.0, breaks the tests.
Version 1.0.0 does not export it's types, so we have to import them from @types/filenamify-url@1.0.0, and I don't know why it breaks the typescript compiler.

That's why I had to do this fix in index.ts

import * as _filenamifyUrl from 'filenamify-url';

 // TODO: update filenamifyUrl and fix the import
const filenamifyUrl = _filenamifyUrl.default;

@sindresorhus
Copy link
Owner

Thanks for working on this 🙌

Please take into account the feedback/reviews I've done in #356.

@sindresorhus
Copy link
Owner

Closing in favor of #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable TypeScript strict mode
2 participants