TDL-6141: Switch from using multipleOf to singer.decimal #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
* TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
* TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code * TDL-14795: Updated code to make compaitable with new tap code structure * TDL-14795: Removed res files Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
* TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error * TDL-14794: Removed content length as Andy suggested in github Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
namrata270998
requested review from
ajmers,
dbshah1212 and
karanpanchal-crest
and removed request for
ajmers
tap_mixpanel/schemas/funnels.json
Outdated
| "format": "date" | ||
| }, | ||
| "datetime": { | ||
| "type": ["null", "string"], | ||
| "type": [ |
There was a problem hiding this comment.
@namrata270998 Re-structuring the "type" array is not expected as part of this PR. Can you please revert this change?
karanpanchal-crest
approved these changes
Sep 24, 2021
umangagrawal-crest
requested review from
luandy64,
cosimon,
KrisPersonal and
zachharris1
KrisPersonal
approved these changes
Oct 26, 2021
* TDL-14840: Updated transform to fix conversion * Tdl 14794 implement tap tester tests (#30) * TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14795 streams and sync should not be dict based (#32) * TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14795 streams and sync should not be dict based (#33) * TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code * TDL-14795: Updated code to make compaitable with new tap code structure * TDL-14795: Removed res files Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14794 implement tap tester tests (#34) * TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error * TDL-14794: Removed content length as Andy suggested in github Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * TDL-14840: Resolved merge conflicts * TDL-14840: Removed extra space * TDL-14840: Removed extra line * Added coverage report to artifact0 * Updated artifact sequence * Added code comment Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com> Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> Co-authored-by: prijendev <88327452+prijendev@users.noreply.github.com>
…pleOf-to-singer-decimal
|
The code change of this PR is already merged in the main branch. Hence, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-6141: Switch from using multipleOf to singer.decimal
Manual QA steps
Risks
Rollback steps