Skip to content

Commit

Permalink
Use typeguard==4.4.0, somacore==1.0.22`
Browse files Browse the repository at this point in the history
fixes #3216
  • Loading branch information
ryan-williams committed Oct 29, 2024
1 parent 212c104 commit 2e79f85
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ repos:
# Pandas 2.x types (e.g. `pd.Series[Any]`). See `_types.py` or https://github.com/single-cell-data/TileDB-SOMA/issues/2839
# for more info.
- "pandas-stubs>=2"
- "somacore==1.0.21"
- "somacore==1.0.22"
- types-setuptools
args: ["--config-file=apis/python/pyproject.toml", "apis/python/src", "apis/python/devtools"]
pass_filenames: false
8 changes: 2 additions & 6 deletions apis/python/requirements_dev.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
black
ruff
pytest
pytest-cov
ruff
sparse
# Python 3.12 support requires https://github.com/agronholm/typeguard/pull/490, which landed between 4.3.0 and 4.4.0.
# However, 4.4.0 also included https://github.com/agronholm/typeguard/pull/496, which causes errors in Python 3.9 (e.g.
# https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11545217103/job/32131849817), so we are pinning to the
# last useful commit here. See also: https://github.com/single-cell-data/TileDB-SOMA/issues/3216.
typeguard @ git+https://github.com/agronholm/typeguard@afad2c7
typeguard==4.4.0
types-setuptools
4 changes: 2 additions & 2 deletions apis/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,8 @@ def run(self):
"pyarrow",
"scanpy>=1.9.2",
"scipy",
# Note: the somacore version is in .pre-commit-config.yaml too
"somacore==1.0.21",
# Note: the somacore version is also pinned in .pre-commit-config.yaml
"somacore==1.0.22",
"typing-extensions", # Note "-" even though `import typing_extensions`
],
extras_require={
Expand Down

0 comments on commit 2e79f85

Please sign in to comment.