Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Upgrade Typeguard to >4.3.0 (once it is available) #3216

Closed
ryan-williams opened this issue Oct 21, 2024 · 3 comments
Closed

[python] Upgrade Typeguard to >4.3.0 (once it is available) #3216

ryan-williams opened this issue Oct 21, 2024 · 3 comments
Assignees
@ryan-williams
Labels
ci long-term-tracker python-api

Comments

@ryan-williams
Copy link
Member

ryan-williams commented Oct 21, 2024 •
edited
Loading

#3001 moves us to installing Typeguard@HEAD, because we need agronholm/typeguard#490 in order for tests/type-checking to pass in Python 3.12):

TileDB-SOMA/apis/python/requirements_dev.txt

Lines 6 to 9 in b7db9ed

# Python 3.12 support requires https://github.com/agronholm/typeguard/pull/490;
# use Typeguard @ HEAD until that PR is included in a release. See also:
# https://github.com/single-cell-data/TileDB-SOMA/issues/3216
typeguard @ git+https://github.com/agronholm/typeguard

Once a new release of Typeguard is available, we should move to that: pypi.org/project/typeguard

cc @johnkerl
@ryan-williams ryan-williams self-assigned this Oct 21, 2024
@ryan-williams ryan-williams mentioned this issue Oct 21, 2024
Merged
@johnkerl
Copy link
Member

Thanks @ryan-williams !

@johnkerl
Copy link
Member

https://github.com/agronholm/typeguard/releases/tag/4.4.0

@ryan-williams ryan-williams mentioned this issue Oct 28, 2024
Closed
@johnkerl
Copy link
Member

johnkerl commented Oct 28, 2024 •
edited
Loading

Additional follow-up needed as flagged here: #3246 (comment)

ryan-williams added a commit that referenced this issue Oct 28, 2024
@ryan-williams
use typeguard==4.4.0
e7d31b7 
fixes #3216
@ryan-williams ryan-williams mentioned this issue Oct 28, 2024
Merged
ryan-williams added a commit that referenced this issue Oct 29, 2024
@ryan-williams
Use typeguard==4.4.0, somacore==1.0.22`
2e79f85 
fixes #3216
github-actions bot pushed a commit that referenced this issue Oct 29, 2024
@ryan-williams @github-actions
Use typeguard==4.4.0, somacore==1.0.22` (#3250)
916fa54 
fixes #3216
johnkerl pushed a commit that referenced this issue Oct 29, 2024
@github-actions @ryan-williams
Use typeguard==4.4.0, somacore==1.0.22` (#3250) (#3254)
dc34c35 
fixes #3216

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan-williams ryan-williams

Labels
ci long-term-tracker python-api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryan-williams @johnkerl