Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Revert "Add Windows support for the Python API" #1959

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Dec 6, 2023

Reverts #1811, which in hindsight I merged prematurely this morning:

We run CI on a bigger matrix post-merge than we do pre-merge -- which:

  • sounds like an opportunity for situations like this, which it is
  • turned out to be absolutely crucial because otherwise we flood CI on every PR commit-push and no one gets anything done 😭
  • So pre-merge CI was green for [python] Add Windows support for the Python API #1811 but post-merge CI had some red spots

I am seeing CI fails like
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/7116127568/job/19375178363

FAILED apis\python\tests\test_basic_anndata_io.py::test_export_obsm_with_holes - Failed: DID NOT RAISE <class 'tiledbsoma._exception.SOMAError'>

but only on certain Python versions -- these need to be investigated.

Also, when I reopen the PR, we should tweak the Python CI to run the "full CI" rather than the "minimal CI" -- pre-push ... then we can do more full coverage pre-push.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1959 (bb3589d) into main (ff491ab) will increase coverage by 26.91%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1959       +/-   ##
===========================================
+ Coverage   62.82%   89.74%   +26.91%     
===========================================
  Files         106       34       -72     
  Lines       10043     3598     -6445     
===========================================
- Hits         6310     3229     -3081     
+ Misses       3733      369     -3364     
Flag Coverage Δ
python 89.74% <100.00%> (+0.64%) ⬆️
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.74% <100.00%> (+0.64%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit e231201 into main Dec 6, 2023
11 of 14 checks passed
@johnkerl johnkerl deleted the revert-1811-windows branch December 6, 2023 15:45
teo-tsirpanis added a commit to teo-tsirpanis/TileDB-SOMA that referenced this pull request Dec 6, 2023
teo-tsirpanis added a commit to teo-tsirpanis/TileDB-SOMA that referenced this pull request Dec 6, 2023
johnkerl pushed a commit that referenced this pull request Dec 6, 2023
* Revert "Revert "Add Windows support for the Python API (#1811)" (#1959)"

This reverts commit e231201.

* Roll back Windows CI.
@johnkerl johnkerl changed the title Revert "Add Windows support for the Python API" [python] Revert "Add Windows support for the Python API" Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant