[python] Full Windows pre-push CI matrix #1962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1962 +/- ##
==========================================
+ Coverage 62.82% 63.10% +0.27%
==========================================
Files 106 106
Lines 10043 10068 +25
==========================================
+ Hits 6310 6353 +43
+ Misses 3733 3715 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@teo-tsirpanis feel free to push commits to this PR whenever 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1811 added Windows support. Pre-push/minimal CI was green, but post-push/full CI was not -- see notes on #1959 -- hence the revert on #1959. Then #1961 restores #1811 to
mainbut without Windows CI. This is the sweet spot: now we have the large Windows PR inmain, with opt-in CI testing here on this PR. CC @teo-tsirpanis and @nguyenv .