Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix last 2.27+Python+dense failing test case #3269

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 31, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Following on #3263 and #3268 which deal with issues with core 2.27 and dense arrays. See also TileDB-Inc/centralized-tiledb-nightlies#25.

There is more work to be done for R tests at 2.27 (#3270) but this resolves the final issue with the Python side.

There is a TODO marked in the code on this PR: there are other cases which would have failed even at 2.26 and below, had they been written. This is addressed on #3271.

Notes for Reviewer:

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (945804c) to head (c69d037).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
+ Coverage   83.81%   83.92%   +0.11%     
==========================================
  Files          51       51              
  Lines        5578     5580       +2     
==========================================
+ Hits         4675     4683       +8     
+ Misses        903      897       -6     
Flag Coverage Δ
python 83.92% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.92% <100.00%> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

johnkerl commented Nov 1, 2024

Thanks @nguyenv !!

@johnkerl johnkerl merged commit 956a68c into main Nov 1, 2024
@johnkerl johnkerl deleted the kerl/python-227-dense-ned-read branch November 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants