Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Fixes for dense+2.27 #3270

Merged
merged 4 commits into from
Nov 1, 2024
Merged

[r] Fixes for dense+2.27 #3270

merged 4 commits into from
Nov 1, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 31, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Fixes for testing with core 2.27 (which is not released yet). See also TileDB-Inc/centralized-tiledb-nightlies#25.

Notes for Reviewer:

Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to produce more informative test failure messages, but otherwise LGTM

apis/r/tests/testthat/test-shape.R Outdated Show resolved Hide resolved
johnkerl and others added 3 commits November 1, 2024 10:47
@johnkerl johnkerl merged commit ae9f951 into main Nov 1, 2024
4 checks passed
@johnkerl johnkerl deleted the kerl/r-227-dense-fixes branch November 1, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants