Close stream with defer #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdknives
approved these changes
Jan 19, 2022
ersonp
force-pushed
the
fix/close-dmsghttp-stream-defer
branch
from
3ef16bf to
319be67
Compare
This commit adds a way to close the stream of dmsg via a defer statement with a go routine in it inside the fun RoundTrip(). The goroutine checks if the response body is closed every one second and if it is closed then we clsoe the stream if not then we keep checking till it's closed or if context is closed.
ersonp
force-pushed
the
fix/close-dmsghttp-stream-defer
branch
from
319be67 to
4feab7f
Compare
This commit contains some minor linting fixes. It also removes a test log and renames the func test used in RoundTrip() to closeStream() and adds a warn log in faliure to close stream and adds a comment detailing how we check if the response body is closed. The todo by evanlinjin is also removed as we won't be reusing the streams as we are now closing them after every use.
ersonp
force-pushed
the
fix/close-dmsghttp-stream-defer
branch
from
44c6089 to
3f08d42
Compare
This commit fixes closeStream() in dmsghttp. The error check is changed from using err strings to using errors.IS to check the error http.ErrBodyReadAfterClose. Also a new error is added to the check, io.EOF. Now we check if there is an error and if the error is equal to either http.ErrBodyReadAfterClose or io.EOF.
This commit fixes the TestHTTPTransport_RoundTrip by removing the timeout from http clients.
mrpalide
approved these changes
Jan 25, 2022
jdknives
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Changes:
RoundTrip()How to test this PR:
Given here : #skywire-1065