Fix MakeHTTPTransport #1065
Merged
Fix MakeHTTPTransport #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds ctx to the MakeHTTPTransport func.
This commit fixes the func isNonceValid() in httpauth. The func isNonceValid() used to replace the original body of the response with the body from ioutil.NopCloser() which caused the res.Body.Close() to not work and so the stream in dmsghttp did not close. Now instead of replacing the body of the response we instead create a new response var auxResp and send it back. Since it is a copy of the original response and not a pointer, the changes to the body of auxResp does not affect the original response.
mrpalide
approved these changes
Jan 25, 2022
jdknives
approved these changes
Jan 25, 2022
This commit updates the dmsg@develop and fixes linting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #
Changes:
How to test this PR:
replace github.com/skycoin/dmsg => ../dmsgingo.modmake dep && make build./skywire-cli config gen -dirt./skywire-visor -c skywire-config.jsondmsg-serverCtrl+Cdmsg-serverNeeds: #dmsg-149