Skip to content

Commit

Permalink
Fix/absence of git in makefile (#1368)
Browse files Browse the repository at this point in the history
* Set version to unknown if git is not installed

* Set commit to unknown if git is not installed

* Remove double quotes from BUILDTAG

This commit removes double quotes from BUILDTAG for Linux and Darwin as the string is saved alongside the double quotes which is not needed.
  • Loading branch information
ersonp authored Sep 19, 2022
1 parent bf51aa0 commit fe423e4
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,24 @@ else
endif
endif

ifeq ($(VERSION),)
VERSION = unknown
endif

ifeq ($(COMMIT),)
COMMIT = unknown
endif

ifeq ($(BUILDTAG),)
ifeq ($(OS),Windows_NT)
BUILDTAG = Windows
else
UNAME_S := $(shell uname -s)
ifeq ($(UNAME_S),Linux)
BUILDTAG = "Linux"
BUILDTAG = Linux
endif
ifeq ($(UNAME_S),Darwin)
BUILDTAG = "Darwin"
BUILDTAG = Darwin
endif
endif
endif
Expand Down

0 comments on commit fe423e4

Please sign in to comment.