Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/absence of git in makefile #1368

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Fix/absence of git in makefile #1368

merged 3 commits into from
Sep 19, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Sep 19, 2022

Did you run make format && make check?

Fixes #1365

Changes:

  • Set version to unknown if empty in makefile
  • Set commit to unknown if empty in makefile

How to test this PR:

@ersonp
Set version to unknown if git is not installed
f842986
@ersonp
Set commit to unknown if git is not installed
3af87ee
@ersonp
Remove double quotes from BUILDTAG
52da952 
This commit removes double quotes from BUILDTAG for Linux and Darwin as the string is saved alongside the double quotes which is not needed.
@0pcom 0pcom self-requested a review September 19, 2022 16:42
0pcom
0pcom approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, except it's not suppressing the error if git is not in the PATH

I set the version of some PKGBUILDs with make version ; so I simply need to change that in those builds to make version | tail -n1

@0pcom 0pcom merged commit fe423e4 into skycoin:develop Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @0pcom