Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the UI work with the new app statuses #1215

Merged
merged 2 commits into from
May 24, 2022
Merged

Make the UI work with the new app statuses #1215

merged 2 commits into from
May 24, 2022

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #1214

Changes:

  • Now the UI considers an app running if the status is not 0 (stopped) or 2 (failed).
  • Now the status 3 is considered “connecting” for all apps.
  • Now the UI shows the error message if an app is in status 2.

How to test this PR:
Go to the app list in the Skywire Manager and start an app. While it is connecting, the status will be yellow. This works on big and small screen sizes.

Also, in the same list, try to start an app and make it end with an error (like stating the vpn-client app with an invalid server). The app status should show the error.

NOTE: the original issue listed status 2 as “connecting”, but that code was used as “failed” and status 3 was the one used as “connecting”, as that is what was seen while testing.

@Senyoret1
Copy link
Contributor Author

The last commit includes a small improvement for how the app list updates the app states after makaing a change.

@mrpalide
Copy link
Contributor

Manually test on mac machine is OK.
mac-test.log

@ersonp ersonp merged commit 5e7e38d into skycoin:develop May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants