Appserver improvements. #357
Conversation
* Combined the appserver.Server and appserver.ProcManager concepts. * Have one rpc.Server per proc. * Various refactoring and renamings.
* Simplified app.Client initialization. * Simplified app logging.
| func (c *ProcConfig) encodeJSON() []byte { | ||
| b, err := json.Marshal(c) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
What do you think about getting rid of panic and just returning an error here?
There was a problem hiding this comment.
I feel like panic is suited here because json.Marshal will only return error if the ProcConfig definition is problematic (which should never happen).
As mentioned on Discord:
|
|
https://discordapp.com/channels/466450852098605059/552769767904116737/709679913309044759 @Darkren wrote:
|
* Separated app-associated functionality within /pkg/visor into /pkg/app/launcher. * Added the concept of visor.BaseConfig() to simplify obtaining default values. * Made startup/shutdown logic modular and introduced init and shutdown stacks. * Shutdown now uses module-based timeouts and wait groups.
Improve visor config and startup/shutdown logic.
Appserver improvements: * Combined the appserver.Server and appserver.ProcManager concepts. * Have one rpc.Server per app proc. * Simplified app.Client initialization. * Visor to App initialization is done via a single env defined for the app PROC_CONFIG which contains a JSON object. * App to Visor initialization is done by App connecting the Visor via app server address. The first 16 bytes that the App sends to Visor is the appcommon.ProcKey. * Changed appcommon.ProcKey format so that it is a deterministic length. * Improved app logging and removed any possibilities of log database race conditions with bbolt. * Various logging improvements. App management, visor config, startup and shutdown improvements: * Separated app-associated functionality within /pkg/visor into /pkg/app/launcher. * Added the concept of visor.BaseConfig() to simplify obtaining default values. * Made startup/shutdown logic modular and introduced init and shutdown stacks. * Shutdown now uses module-based timeouts and wait groups. Changes as suggested by @Darkren and @nkryuchkov Former-commit-id: 6c4c0d5
Fixes #338
Changes:
appserver.Serverandappserver.ProcManagerconcepts.rpc.Serverper app proc.app.Clientinitialization.PROC_CONFIGwhich contains a JSON object.appcommon.ProcKey.appcommon.ProcKeyformat so that it is a deterministic length.bbolt.