Improve reliability and logging of setup node. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split setup node into multiple functions for easier testability. * Check inputs for each setup request. * Use context.Context in all parts of the setup process to ensure we cancel on hard timeout. * Introduced routerclient.Map to clean up various parts of the logic, as well as allow the setup process to be speedier. * Got rid of the routing.Path data type as it is confusing. I has resorted to use []routing.Hop directly. * Unit tests.
evanlinjin
force-pushed
the
fix/setup-node-hangs
branch
from
0c0c05c to
82263cd
Compare
evanlinjin
changed the title
* Rewrote setup.Node tests. * Various tweaks/renamings.
nkryuchkov
suggested changes
Jun 5, 2020
Actual dialing to the snettest.Env struct has also been temporarily removed. This will be addressed in #395
nkryuchkov
approved these changes
Jun 8, 2020
jdknives
pushed a commit
that referenced
this pull request
Oct 19, 2020
Improve reliability and logging of setup node. Former-commit-id: 0b19237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379
Changes:
How to test this PR:
make checkskywire-servicesinteractive env to work with these changes.