Improvements for the update procedure #453
Merged
+789
−334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
?The go code was not changed.
npm run lint
andnpm run build
were used.Changes:
A new modal window for updating the visors was added. Is has several advantages:
Other changes are:
How to test this PR:
Use the update options in the visor list and the visor details pages.
Known problem:
If you use the option for updating all visors, in the visor list, the UI will call the
visors/${nodeKey}/update/ws
API endpoint for all of them and will show progress for all of them. However, all visors will show the same progress, but the command window of just one visor will show progress.This means that when calling the
visors/${nodeKey}/update/ws
API endpoint several times for updating several visors, only one visor will be updated and all web sockets will show the progress of that single visor, not mater for which visor the web socket was created.This can be tested using
make integration-run-generic
.cc @nkryuchkov