Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visor RPC timeouts #454

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Fix visor RPC timeouts #454

merged 2 commits into from
Jul 31, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #452

Changes:

  • Fix visor RPC timeouts

How to test this PR:

  • Run updating using a very slow internet connection

@nkryuchkov nkryuchkov requested a review from Senyoret1 July 31, 2020 08:22
Senyoret1
Senyoret1 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@Senyoret1 Senyoret1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for solving the issue 👍

@jdknives jdknives merged commit d225258 into skycoin:develop Jul 31, 2020
@nkryuchkov nkryuchkov deleted the fix/rpc-timeouts branch August 3, 2020 10:07
@nkryuchkov nkryuchkov linked an issue Aug 3, 2020 that may be closed by this pull request
The web socket for updating the nodes only lasts for 5 mins #452
Closed
@Senyoret1 Senyoret1 mentioned this pull request Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@Senyoret1 Senyoret1 Senyoret1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The web socket for updating the nodes only lasts for 5 mins
3 participants
@nkryuchkov @Senyoret1 @jdknives