Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock in managed tp's updateStatus #700

Merged
merged 5 commits into from
Feb 27, 2021
Merged

Fix deadlock in managed tp's updateStatus #700

merged 5 commits into from
Feb 27, 2021

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Feb 26, 2021

Did you run make format && make check?
Yes
Fixes #692

Changes:

  • Fixed deadlock which caused visor going offline in hypervisor UI

How to test this PR:

  1. Run visor with VPN server, visor with VPN client and visor with hypervisor on 3 different machines
  2. Prepare another machine to access hypervisor UI, access the visors page
  3. Start VPN client with killswitch
  4. Update visors page, and right after it gets loaded, remove transport from the VPN server side
  5. Wait like 20-30 seconds, visor should stay online in the UI

@Darkren Darkren changed the title [WIP] Fix deadlock in managed tp's updateStatus Fix deadlock in managed tp's updateStatus Feb 26, 2021
This was referenced Feb 27, 2021
Closed
Closed
@jdknives jdknives merged commit 19d88de into skycoin:develop Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darkren @jdknives