[gui] Map file handle mode setting having no effect after settings upgrade from version 15 to 16

[CmP-lt]

If deobfuscationForceSave is true when setting are upgraded from version 15 to 16

jadx/jadx-gui/src/main/java/jadx/gui/settings/JadxSettings.java

Lines 697 to 704 in b4fa664

	if (fromVersion == 15) {
	if (deobfuscationForceSave) {
	deobfuscationMapFileMode = DeobfuscationMapFileMode.OVERWRITE;
	} else {
	deobfuscationMapFileMode = DeobfuscationMapFileMode.READ;
	}
	fromVersion++;
	}

the value will be saved in settings and there will be no way to set it to false from the application itself.

This causes the problem of deobfuscationMapFileMode being set to DeobfuscationMapFileMode.OVERWRITE regardless of which option is chosen in preference window:

jadx/jadx-cli/src/main/java/jadx/cli/JadxCLIArgs.java

Lines 262 to 266 in b4fa664

	if (deobfuscationForceSave) {
	args.setDeobfuscationMapFileMode(DeobfuscationMapFileMode.OVERWRITE);
	} else {
	args.setDeobfuscationMapFileMode(deobfuscationMapFileMode);
	}

That puts user in situation of having no control over map file handle mode, since it is forcefully overridden to OVERWRITE after saved settings are loaded on application startup.

The problem can be addressed using any of the following approaches (although there may be better ones):

• set deobfuscationForceSave to false in the code for handling settings upgrade from version 15 to 16;
• exclude deobfuscationForceSave from being saved (since it has been removed from preferences window).

[skylot]

@CmP-lt thanks! This field, supposed to be excluded from saving in jadx-gui. But I think now it can be safely removed as it deprecated for several versions already.

[skylot]

Done, field removed.