Picker rotating when host view controller fixed to portrait

[jonathan2708]

In my app target settings I've ticked all orientations except for 'Upside Down'. In most view controllers I've limited the orientation to 'Portrait' by using the following code :

-(NSUInteger)supportedInterfaceOrientations {
return UIInterfaceOrientationMaskPortrait;
}

This locks the view controller to portrait, but the ActionSheetPicker doesn't respect this and animates itself to landscape when the device is rotated. It also has the effect of taking the status bar with it so this ends up displayed along the long edge of the phone.

How should I use the control so that it either locks to portrait, or dismisses when the device is rotated? I'm building with Xcode 6/iOS 8 SDK.

[skywinder]

Hi. Now you can't do anything with orientation of the picker. And it's really can cause problems.
In the way to resolve this issue - it's needed to implement additional property for picker, to specify orientations, that it should support. I will try to fix it soon.

[skywinder]

Fixed. I add property supportedInterfaceOrientations.
Now you can specify what orientations you would like to support.

[jonathan2708]

Hi, I'm trying to use this new property by setting it to UIInterfaceOrientationMaskPortrait but I'm still getting the same animation effect when the device is rotated. Am I doing something wrong? How can the picker be locked for rotation? I've updated to version 1.3.10.

[skywinder]

@jonathan2708 ok, I reopen issue. I try to fix it soon.
Can you show me example of code, how you init picker and set supportedInterfaceOrientations property?

[jonathan2708]

Hi, many thanks for looking into this. I've pasted the code I'm using below, and included a screenshot too.

ActionSheetDatePicker *datePicker = [[ActionSheetDatePicker alloc] initWithTitle:@"Select Date" datePickerMode:UIDatePickerModeDate selectedDate:defaultDate target:self action:@selector(dateWasSelected:element:) origin:sender];
[datePicker setSupportedInterfaceOrientations:UIInterfaceOrientationMaskPortrait];
[datePicker setDoneButton:btnPickerDone];
[datePicker setCancelButton:btnPickerCancel];
[datePicker showActionSheetPicker];

[ralito]

I am having the exact same problem. The picker is ignoring the value that is set to supportedInterfaceOrientations property.

[Morpheus2002]

+1

[skywinder]

@ralito , @Morpheus2002 Can't reproduce, thus can't fix it. Can you give me more info, how to reproduce it?

[Morpheus2002]

I locked the presenting view to portrait mode with this functions:

- (UIInterfaceOrientation)preferredInterfaceOrientationForPresentation
{
    return UIInterfaceOrientationPortrait;
}

- (NSUInteger)supportedInterfaceOrientations
{
        return UIInterfaceOrientationMaskPortrait;
}


- (BOOL)shouldAutorotate
{
    return NO;   
}

As on the screenshot above from @jonathan2708 the app itself stays in portrait mode, but the picker view is rotated and loses background color.

Not using

[datePicker setSupportedInterfaceOrientations:UIInterfaceOrientationMaskPortrait];

[skywinder]

@jonathan2708 , @ralito , @Morpheus2002 fixed in 1.5.0

[gabula80]

The issue still persists. Scenario to reproduce:

• Lock the interface in UIViewController to Portrait by overriding supportedInterfaceOrientations and returning UIInterfaceOrientationMaskPortrait.
• Set the picker to supportedInterfaceOrientations to Portrait using set setSupportedInterfaceOrientations. Note that it is reproducible with both this property set and not set.
• Leave the phone in portrait and perform the action that opens the picker (like pressing a button).
• Rotate to landscape. The ViewController will not rotate and remain in portrait, but the picker will rotate and mess up its background as shown in the pic from @jonathan2708

[jonathan2708]

I agree with @gabula80 - still not fixed in 1.5.0. As a temporary fix for my portrait-only app I have made the following change to SWActionSheet.m :

-(NSUInteger)supportedInterfaceOrientations {
    //return UIInterfaceOrientationMaskAll;
    return UIInterfaceOrientationMaskPortrait;
}

[skywinder]

Ok, I reopen this issue.

[ralito]

Since my app support all interface orientations for iPad and only Portrait for iPhone as a temporary solution in the SWActionSheet.m I implemented :

• (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation
• (NSUInteger)supportedInterfaceOrientations

I hope this helps someone. :)

[tbaranes]

Same issue here. The picker is dismissed well when I'm rotating, but the application is rotating anyway. I didn't look too deep, but this looks weir for me in SWActionSheet:

-(NSUInteger)supportedInterfaceOrientations{
    return UIInterfaceOrientationMaskPortrait;
}

That should return the orientation set in the application / AbstractActionSheetPicker to respect the orientation setup, isn't it?

[skywinder]

@tbaranes the main point is detect orientation of application. and dismiss picker only when application is willRotate. I didn't find clean solution yet.

[tbaranes]

Should the picker really be dismissed? I mean, if the orientation isn't available for the device, the picker should just stay open in place like the rest of the application. It should be the developer's choice to dismiss it or not following the case.

Moreover, that would probably make easier to solve this issue.

[skywinder]

@tbaranes I like the way you think. 👍 This behaviour looks logically and clear.

[pahnev]

I believe this bug has made it's way back.

[FedericoHenze]

This is still happening, how is the appropriate way to avoid the rotation of the picker?

[jignesh133]

i am not able to change the cancel and Done buttons colour,and picker text colour.

[MyNameIsWood]

@jonathan2708
paste the following code in SWActionSheetVC/@implementation SWActionSheetVC:
`- (UIInterfaceOrientationMask)supportedInterfaceOrientations {

return UIInterfaceOrientationMaskPortrait;

}
`