Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for upside down portrait; #149

Merged
merged 1 commit into from
Mar 5, 2015

Conversation

dtrauger
Copy link

@dtrauger dtrauger commented Mar 5, 2015

We ran into the same issue described in #52 which was closed without resolution. The issue relates to the action sheet opening from the top of the screen upside down in relation to the device's actual orientation.

This PR:

  1. fix upside down portrait mode displays incorrectly on iPhone 4S device/emulator #52
  2. fix Picker rotating when host view controller fixed to portrait #100
  3. fix upside down portrait mode displays incorrectly #146

@skywinder
Copy link
Owner

@dtrauger Thanks! 👍
This fix should also resolve #100, right?

@dtrauger
Copy link
Author

dtrauger commented Mar 5, 2015

Yes, this addresses #100 as well.

On Thu, Mar 5, 2015 at 10:24 AM, Petr Korolev notifications@github.com
wrote:

@dtrauger https://github.com/dtrauger Thanks! [image: 👍]
This fix should also resolve #100
#100, right?


Reply to this email directly or view it on GitHub
#149 (comment)
.

@skywinder
Copy link
Owner

@dtrauger and should fix #146, right? 😄

@dtrauger
Copy link
Author

dtrauger commented Mar 5, 2015

Yes, this addresses #146 as well.

On Thu, Mar 5, 2015 at 10:26 AM, Petr Korolev notifications@github.com
wrote:

@dtrauger https://github.com/dtrauger and should fix #146
#146, right? [image:
😄]


Reply to this email directly or view it on GitHub
#149 (comment)
.

@skywinder
Copy link
Owner

@dtrauger You are awesome! Thanks a lot! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants