Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese: new custom routes document translation #1136 #1137

Closed
4 of 10 tasks
seratch opened this issue Sep 28, 2021 · 0 comments · Fixed by #1169
Closed
4 of 10 tasks

Japanese: new custom routes document translation #1136 #1137

seratch opened this issue Sep 28, 2021 · 0 comments · Fixed by #1169
Assignees
@wongjas
Labels
docs M-T: Documentation work only good first issue Good for newcomers
Milestone
3.8.0

Comments

@seratch
Copy link
Member

seratch commented Sep 28, 2021

Description

Bring the changes in #1136 to the Japanese one.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added docs M-T: Documentation work only good first issue Good for newcomers labels Sep 28, 2021
@seratch seratch added this to the 3.x milestone Sep 28, 2021
@wongjas wongjas self-assigned this Oct 18, 2021
@wongjas wongjas mentioned this issue Oct 19, 2021
Merged
2 tasks
seratch added a commit that referenced this issue Oct 19, 2021
@wongjas @seratch
Fixes #1137, adds JP translation for custom routes (#1169)
3495b12 
* add first draft for custom routes
* proofread and add changes
* Add Kaz's comment fixes
* Update docs/_advanced/ja_custom_routes.md

Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@seratch seratch modified the milestones: 3.x, 3.8.0 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wongjas wongjas

Labels
docs M-T: Documentation work only good first issue Good for newcomers
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Fixes #1137, adds JP translation for custom routes
2 participants
@seratch @wongjas