Fixes #1137, adds JP translation for custom routes #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 15 15
Lines 1354 1354
Branches 402 402
=======================================
Hits 971 971
Misses 312 312
Partials 71 71 Continue to review full report at Codecov.
|
seratch
requested changes
Oct 19, 2021
docs/_advanced/ja_custom_routes.md
Outdated
| @@ -6,9 +6,43 @@ order: 9 | |||
| --- | |||
|
|
|||
| <div class="section-content"> | |||
| `v3.7.0` から `App` を初期化する時、 `customRoutes` というルートの配列を渡し、カスタムHTTPルートを簡単に追加できます。 | |||
There was a problem hiding this comment.
Suggested change
| `v3.7.0` から `App` を初期化する時、 `customRoutes` というルートの配列を渡し、カスタムHTTPルートを簡単に追加できます。 | |
| `v3.7.0` から `App` を初期化する際に `customRoutes` というルートの配列を渡すことでカスタムの HTTP ルートを簡単に追加できるようになりました。 |
docs/_advanced/ja_custom_routes.md
Outdated
|
|
||
| Bolt の組み込みの `ExpressReceiver` を使っているなら、カスタムの HTTP ルートを追加するのはとても簡単です。`v2.1.0` から `ExpressReceiver` には `router` というプロパティが追加されています。これは、さらにルートを追加できるように `App` 内部で保持している Exprss の [Router](http://expressjs.com/en/4x/api.html#router) を public にしたものです。 | ||
| 各 `CustomRoute` オブジェクトには `path` 、 `method` と `handler` という三つのプロパティを必要とします。 HTTP 動詞に相当する `method` は文字列または文字列の配列です。 |
There was a problem hiding this comment.
- You don't need to have "と" for "and" here.
- 必要とする is fine but perhaps 含まれている必要がある should be more natural here.
- Indeed, verb is 動詞 but "HTTP 動詞" does not make sense. Let's use HTTP メソッド instead (no need to revise the English sentence).
Suggested change
| 各 `CustomRoute` オブジェクトには `path` 、 `method` と `handler` という三つのプロパティを必要とします。 HTTP 動詞に相当する `method` は文字列または文字列の配列です。 | |
| 各 `CustomRoute` オブジェクトには `path` 、 `method`、 `handler` という三つのプロパティが含まれていなければなりません。 HTTP メソッドに相当する `method` は文字列または文字列の配列です。 |
There was a problem hiding this comment.
Thank you for pointing that out!
seratch
reviewed
Oct 19, 2021
seratch
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1137. Adds JP translation for custom routes.
Requirements (place an
xin each[ ])