Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable developers to customize the built-in receivers more #860

Closed
4 of 10 tasks
seratch opened this issue Mar 29, 2021 · 0 comments · Fixed by #1183
Closed
4 of 10 tasks

Enable developers to customize the built-in receivers more #860

seratch opened this issue Mar 29, 2021 · 0 comments · Fixed by #1183
Assignees
Labels
enhancement M-T: A feature request for new functionality semver:minor
Milestone

Comments

@seratch
Copy link
Member

seratch commented Mar 29, 2021

Description

The error handling parts of the built-in receivers are not customizable for developers.

For instance, if a developer would like to customize HTTPReceiver's error handling logic (e.g., send a different HTTP status code in accordance with Bolt error code, add extra lines of code such as logging), there is no way apart from creating their own custom receiver.

The built-in receivers can accept functions as part of constructor arguments for customizing those parts.

We may want to add more customizable points than the error handling parts. Please let us know if you have thoughts or ideas about this topic.

See also: slackapi/bolt-python#273
(Please note that, as Bolt for Python / Java do not follow the concept "Receiver", the solution can be a bit different though the goal in the issue is the same)

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added enhancement M-T: A feature request for new functionality semver:minor labels Mar 29, 2021
@seratch seratch added this to the 3.5.0 milestone Mar 29, 2021
@seratch seratch self-assigned this Mar 29, 2021
@seratch seratch modified the milestones: 3.5.0, 3.6.0 Jul 2, 2021
@srajiang srajiang modified the milestones: 3.6.0, 3.7.0 Aug 19, 2021
@seratch seratch modified the milestones: 3.7.0, 3.8.0 Aug 23, 2021
@seratch seratch modified the milestones: 3.8.0, 3.9.0 Oct 26, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Oct 29, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Oct 29, 2021
@seratch seratch modified the milestones: 3.9.0, 3.8.0 Oct 29, 2021
seratch added a commit to seratch/bolt-js that referenced this issue Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants