-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #860 Enable developers to customize the built-in receivers more #1183
Fix #860 Enable developers to customize the built-in receivers more #1183
Conversation
d6028aa
to
a2da515
Compare
I've set the milestone to v3.9 but if other maintainers are fine, I'm happy to move this to v3.8 (the next release) |
Codecov Report
@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 71.42% 72.22% +0.79%
==========================================
Files 17 17
Lines 1414 1433 +19
Branches 424 430 +6
==========================================
+ Hits 1010 1035 +25
+ Misses 332 322 -10
- Partials 72 76 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What sorts of documentation updates should go with this? Looking at the docs on Handling Errors, there is only mention of app.error
in there - would that be a good place to add this functionality to? Another option would possibly be the Customizing Receiver docs? What do you think?
Yes, this is a really good point. We should update the error handling section. Also, we can update the reference page as well. |
OK, sounds good. I am happy to write those up if you wish. |
Nice! Let's start with creating a task issue for it 👍 |
Sounds good, created #1187 - if you'd like for me to work on it, please just assign me. |
I'm thinking that we can have this in v3.8 next week. Before merging this, I wait for others' feedback / reviews by the end of next Modany, Pacific Time. Feel free to write in if you have any! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Kaz!!
42c4077
to
9c2d8a7
Compare
Summary
This pull request adds a few customizable handlers to the default Receiver -- HTTPReceiver.
To: reviewers
I'm happy to elaborate more on details! but please refer to the comments in the diff first to learn the reason why these handlers can be useful.
Notes on other built-in receivers:
Fixes #860
Requirements (place an
x
in each[ ]
)