Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded on error handling docs #1425

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Expanded on error handling docs #1425

merged 3 commits into from
Apr 19, 2022

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Apr 18, 2022

These docs are related to #1183 and fixes #1187.

Would love some help on the Japanese docs 😄

… handlers. Added these to the reference docs too. Related to #1183, fixes #1187.
@filmaj filmaj added the docs M-T: Documentation work only label Apr 18, 2022
@filmaj filmaj requested a review from seratch April 18, 2022 22:02
@filmaj filmaj self-assigned this Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1425 (2bee79c) into main (97f6ea2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1425   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          18       18           
  Lines        1476     1476           
  Branches      434      434           
=======================================
  Hits         1210     1210           
  Misses        172      172           
  Partials       94       94           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f6ea2...2bee79c. Read the comment docs.

@seratch
Copy link
Member

seratch commented Apr 18, 2022

@filmaj Can you resolve the conflicts?

@@ -9,9 +9,48 @@ order: 1
*Note: Since v2, error handling has improved! View the [migration guide for V2](https://slack.dev/bolt/tutorial/migration-v2) to learn about the changes.*

If an error occurs in a listener, it’s recommended you handle it directly with a `try`/`catch`. However, there still may be cases where errors slip through the cracks. By default, these errors will be logged to the console. To handle them yourself, you can attach a global error handler to your app with the `app.error(fn)` method.

You can also define more focussed and specific error handlers for a variety of error paths directly on the `HTTPReceiver`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add the corresponding changes to the JP docs later

docs/_tutorials/ja_reference.md Outdated Show resolved Hide resolved
@seratch seratch merged commit 68ebfdf into main Apr 19, 2022
@seratch seratch deleted the docs-more-error-handlers branch April 19, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
2 participants