Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve/ignore eslint warnings #1095

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Resolve/ignore eslint warnings #1095

merged 2 commits into from
Aug 29, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 28, 2021

Summary

This pull request resolves/ignores 240 eslint warnings. For tests, this PR basically ignores warnings for entire files. As for the library code, it depends on what the warnings are.

/Users/ksera/github/bolt-js/src/App.spec.ts
    29:41  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
    31:40  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   112:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   126:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   141:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   156:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   182:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   196:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   458:17  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
   459:17  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
   478:17  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
   492:19  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
   493:25  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   575:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   662:40  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1191:19  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  1244:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1254:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1292:19  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  1343:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1353:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1610:19  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  1658:19  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  1721:19  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  1867:34  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1897:34  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1910:67  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1972:41  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  1997:34  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/App.ts
  130:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  137:62  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  370:7   warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  399:24  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  458:24  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  696:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  769:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  897:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/WorkflowStep.spec.ts
  298:15  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion

/Users/ksera/github/bolt-js/src/WorkflowStep.ts
   36:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   39:24  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   54:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  152:34  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  156:14  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  349:39  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  351:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/conversation-store.spec.ts
  165:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  186:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/conversation-store.ts
   7:56  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  19:46  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  55:57  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  67:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  77:11  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion

/Users/ksera/github/bolt-js/src/helpers.spec.ts
  130:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  160:55  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  174:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  196:29  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/helpers.ts
  30:46  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  54:14  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion

/Users/ksera/github/bolt-js/src/middleware/builtin.spec.ts
  388:10  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  518:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/middleware/builtin.ts
   43:9   warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
   60:9   warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
   74:9   warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
   88:9   warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  102:9   warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  116:9   warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  204:11  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  237:11  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  252:11  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  289:11  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  323:11  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  331:13  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion
  368:11  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion

/Users/ksera/github/bolt-js/src/receivers/AwsLambdaReceiver.spec.ts
  13:31  warning  Unexpected unnamed function               func-names
  14:14  warning  Unexpected unnamed function               func-names
  17:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  20:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  23:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  26:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/receivers/AwsLambdaReceiver.ts
   11:12  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   12:22  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   16:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   17:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   18:36  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   19:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   20:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   24:68  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   38:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   75:15  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   89:15  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   99:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  106:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  206:98  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  257:50  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/receivers/ExpressReceiver.spec.ts
   22:40   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   32:39   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   46:29   warning  Unexpected unnamed function               func-names
   47:14   warning  Unexpected unnamed function               func-names
   53:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   56:19   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   59:19   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   62:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   76:42   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   86:14   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   88:10   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  136:26   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  137:29   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  138:30   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  142:24   warning  Unexpected unnamed function               func-names
  143:78   warning  Unexpected unnamed async function         func-names
  161:115  warning  Unexpected unnamed async function         func-names
  181:106  warning  Unexpected unnamed async function         func-names
  196:23   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  203:99   warning  Unexpected unnamed async function         func-names
  218:23   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  228:21   warning  Unexpected unnamed function               func-names
  229:93   warning  Unexpected unnamed async function         func-names
  247:68   warning  Unexpected unnamed async function         func-names
  260:23   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  271:52   warning  Unexpected unnamed function               func-names
  272:56   warning  Unexpected unnamed async function         func-names
  304:26   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  305:30   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  326:26   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  327:30   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  350:26   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  351:30   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  372:26   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  373:30   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  410:40   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  420:42   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  437:14   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  442:28   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  453:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  460:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  467:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  477:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  487:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  501:21   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  519:40   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  529:42   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  546:21   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  563:40   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  575:40   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  584:42   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  600:21   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  618:40   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  634:21   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  660:21   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  678:40   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  688:42   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/receivers/ExpressReceiver.ts
  190:22  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  202:15  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  208:29  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  210:21  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  284:24  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  406:29  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  406:43  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  441:59  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  489:27  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  508:29  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  508:43  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  527:81  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/receivers/HTTPReceiver.spec.ts
   46:39  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   60:26  warning  Unexpected unnamed function               func-names
   61:14  warning  Unexpected unnamed function               func-names
   62:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   62:39  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   66:40  warning  Unexpected unnamed function               func-names
   66:53  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   66:73  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   66:83  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   73:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   76:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   79:19  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   82:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   96:27  warning  Unexpected unnamed function               func-names
   98:89  warning  Unexpected unnamed async function         func-names
  121:32  warning  Unexpected unnamed function               func-names
  122:95  warning  Unexpected unnamed async function         func-names
  163:74  warning  Unexpected unnamed async function         func-names
  207:62  warning  Unexpected unnamed async function         func-names
  249:89  warning  Unexpected unnamed async function         func-names
  294:99  warning  Unexpected unnamed async function         func-names

/Users/ksera/github/bolt-js/src/receivers/HTTPReceiver.ts
  216:28  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  291:20  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  300:54  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  300:73  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  321:17  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  334:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  348:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  427:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  457:49  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  457:66  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  481:26  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  491:50  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  491:67  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion

/Users/ksera/github/bolt-js/src/receivers/SocketModeReceiver.spec.ts
   22:39   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   36:32   warning  Unexpected unnamed function               func-names
   37:14   warning  Unexpected unnamed function               func-names
   38:28   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   38:39   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   42:40   warning  Unexpected unnamed function               func-names
   42:65   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   42:75   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   49:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   52:19   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   55:19   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   58:20   warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   72:27   warning  Unexpected unnamed function               func-names
   74:89   warning  Unexpected unnamed async function         func-names
   97:67   warning  Unexpected unnamed async function         func-names
  122:96   warning  Unexpected unnamed async function         func-names
  164:95   warning  Unexpected unnamed async function         func-names
  204:74   warning  Unexpected unnamed async function         func-names
  247:63   warning  Unexpected unnamed async function         func-names
  289:106  warning  Unexpected unnamed async function         func-names
  330:24   warning  Unexpected unnamed function               func-names
  331:59   warning  Unexpected unnamed async function         func-names
  358:23   warning  Unexpected unnamed function               func-names
  359:64   warning  Unexpected unnamed async function         func-names

/Users/ksera/github/bolt-js/src/receivers/SocketModeReceiver.ts
   91:22  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  109:17  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  112:31  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  114:23  warning  Forbidden non-null assertion              @typescript-eslint/no-non-null-assertion
  128:30  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/test-helpers.ts
  7:27  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/actions/block-action.ts
  233:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  245:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/actions/workflow-step-edit.ts
  32:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/events/base-events.ts
  885:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/events/message-events.ts
  350:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  357:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/helpers.ts
  4:44  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/options/index.ts
  215:16  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/receiver.ts
   9:14  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  14:18  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  15:17  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/shortcuts/message-shortcut.ts
  18:20  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/Users/ksera/github/bolt-js/src/types/utilities.ts
  42:49  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 240 problems (0 errors, 240 warnings)

Requirements (place an x in each [ ])

@seratch seratch added this to the 3.7.0 milestone Aug 28, 2021
@seratch seratch self-assigned this Aug 28, 2021
@gitwave gitwave bot added the untriaged label Aug 28, 2021
@codecov
Copy link

codecov bot commented Aug 28, 2021 •
edited
Loading

Codecov Report

Merging #1095 (f5e1191) into main (8326547) will decrease coverage by 0.19%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   69.50%   69.31%   -0.20%     
==========================================
  Files          13       13              
  Lines        1279     1284       +5     
  Branches      376      380       +4     
==========================================
+ Hits          889      890       +1     
- Misses        319      320       +1     
- Partials       71       74       +3
Impacted Files Coverage Δ
src/WorkflowStep.ts 90.69% <ø> (ø)
src/conversation-store.ts 100.00% <ø> (ø)
src/helpers.ts 80.95% <ø> (ø)
src/middleware/builtin.ts 83.84% <ø> (ø)
src/receivers/AwsLambdaReceiver.ts 60.00% <ø> (ø)
src/receivers/ExpressReceiver.ts 58.46% <0.00%> (-0.61%) ⬇️
src/receivers/HTTPReceiver.ts 32.27% <ø> (ø)
src/receivers/SocketModeReceiver.ts 67.21% <0.00%> (-2.28%) ⬇️
src/App.ts 83.55% <66.66%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8326547...f5e1191. Read the comment docs.

filmaj
filmaj approved these changes Aug 28, 2021
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

One slight tweak as an alternative: what if we disabled certain rules for test files? no-explicit-any, no-non-null-assertion and func-names seem like heavy-handed rules for tests. We can add test-file-specific rules easily now to a specific section of the eslintrc.js file.

@mwbrooks mwbrooks added semver:patch tests M-T: Testing work only and removed untriaged labels Aug 28, 2021
@mwbrooks
Copy link
Member

This must have been a lot of work. Thanks for taking it on! I wonder if @filmaj's comment will help keep this maintainable in the future by setting test-specific rules.

misscoded
misscoded approved these changes Aug 29, 2021
View reviewed changes
Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan going forward if we opt to suppress the violation of rules we've decided on instead of fixing them? Just no new warnings going forward? My main concern with side-stepping/suppressing them is that they'll end up like TODOs generally do: out of sight and out of mind.

@seratch
Copy link
Member Author

seratch commented Aug 29, 2021

@filmaj
Thanks for the suggestion! I've moved the repeated eslint-disable to .eslintrc.js

@misscoded
We still can improve these issues in future pull requests! My top priority in this pull request is to improve the situation where we are seeing an unmanageable number of warnings without breaking anything.

For future reference, we had 240 warnings but actually all of them on the main code side are "no-explicit-any" and "no-non-null-assertion".

Regarding "no-explicit-any", changing any types in code is not so simple. It needs careful research and tests.

As for "no-non-null-assertion", we already have many TODO comments about it. For instance, next argument in middleware always exists for sure but it's optional in bolt-js's typing (this issue has been a TODO from the beginning). Once we resolve the typing issue, we can remove the ! calls from code.

@seratch seratch merged commit 992b64a into slackapi:main Aug 29, 2021
@seratch seratch deleted the eslint-warnings branch August 29, 2021 08:21
seratch added a commit to seratch/bolt-js that referenced this pull request Aug 30, 2021
@seratch
Fix eslint warnings in getting-started-typescript app (ref slackapi#1095
972c34f 
)
@seratch seratch mentioned this pull request Aug 30, 2021
Merged
2 tasks
seratch added a commit that referenced this pull request Aug 30, 2021
@seratch
Fix eslint warnings in getting-started-typescript app (ref #1095) (#1097
43e53ec 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misscoded misscoded misscoded approved these changes

@filmaj filmaj filmaj approved these changes

@mwbrooks mwbrooks mwbrooks approved these changes

@srajiang srajiang Awaiting requested review from srajiang

Assignees

@seratch seratch

Labels
semver:patch tests M-T: Testing work only
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@seratch @mwbrooks @filmaj @misscoded