Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint warnings in getting-started-typescript app (ref #1095) #1097

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 30, 2021

Summary

This pull request resolves all the eslint warnings in getting-started-typescript example app project. This is an improvement in addition to #1095

Requirements (place an x in each [ ])

@seratch seratch added TypeScript-specific area:examples issues related to example or sample code labels Aug 30, 2021
@seratch seratch added this to the 3.7.0 milestone Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #1097 (972c34f) into main (992b64a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   69.31%   69.31%           
=======================================
  Files          13       13           
  Lines        1284     1284           
  Branches      380      380           
=======================================
  Hits          890      890           
  Misses        320      320           
  Partials       74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992b64a...972c34f. Read the comment docs.

@seratch seratch self-assigned this Aug 30, 2021
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for doing this.

Related, do we want the main npm run lint task to also lint the example apps?

@seratch
Copy link
Member Author

seratch commented Aug 30, 2021

@filmaj

Related, do we want the main npm run lint task to also lint the example apps?

I think this is a good idea for the TS example app.

@seratch seratch merged commit 43e53ec into slackapi:main Aug 30, 2021
@seratch seratch deleted the fix-ts-example branch August 30, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:examples issues related to example or sample code TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants